Skip to content
This repository was archived by the owner on Dec 10, 2019. It is now read-only.

Material Skin and Dark Mode#4

Merged
megalon merged 14 commits into
bsmg:masterfrom
lnx00:master
Apr 8, 2019
Merged

Material Skin and Dark Mode#4
megalon merged 14 commits into
bsmg:masterfrom
lnx00:master

Conversation

@lnx00
Copy link
Copy Markdown

@lnx00 lnx00 commented Apr 6, 2019

I've updated the UI using the Material Skin provided by IgnaceMaes and fixed a bug where the installation path was set to NULL when you click abort on the folder browse dialog.
You are also able to select a dark mode in the new options tab.

Assistant and others added 5 commits April 6, 2019 13:34
Overhauled interface with Material Skin and Dark Theme
The Theme Choice will now be saved and the updater will run in a new Thread to prevent it from holding up the whole form.
@megalon
Copy link
Copy Markdown
Member

megalon commented Apr 6, 2019

Wow, this looks great, thanks for making this!

I think that the dark theme could use a little color tweaking.
The categories are really hard to read, and I think that the dependencies highlighting is a bit too dark, but it's not that bad.

@megalon
Copy link
Copy Markdown
Member

megalon commented Apr 6, 2019

image
As you can see it's pretty hard to read the categories

@lnx00
Copy link
Copy Markdown
Author

lnx00 commented Apr 6, 2019

Yes, but I'm still trying to figure out how to change the color of the GroupNames. Apparently it's not that easy to change them. I gonna have to change them using an override or something like that :/

Assistant and others added 7 commits April 6, 2019 16:09
lnx00 and others added 2 commits April 7, 2019 16:10
Added some new Themes:
Blue/Grey, Green, Orange, Blue, Red
@megalon
Copy link
Copy Markdown
Member

megalon commented Apr 8, 2019

It looks like you can't change the color of the text for a ListViewGroup
https://stackoverflow.com/questions/3073389/win32-list-view-group-header-text-color

Instead of using ListViewGroups, we could have a single group and simply have each category label as a special ListViewItem with it's own color scheme.

I've noticed that there is no minimum window size when using the material skin, so it's possible to make the window disappear down to nearly a single pixel.
Edit: This is easy enough to fix by setting minimum size within FormMain.cs

@megalon
Copy link
Copy Markdown
Member

megalon commented Apr 8, 2019

Going to go ahead and merge this, then add in the minimum size after, and make a few tweaks to the theme as well. Thanks!

@megalon megalon merged commit 5d535dc into bsmg:master Apr 8, 2019
@megalon
Copy link
Copy Markdown
Member

megalon commented Apr 8, 2019

I ended up reverting this merge because your branch has the dependencies code that does not work properly, and I was unable to easily remove it.
I'm going to try to remove it again from your fork, but for now I'd rather not have it in the master branch.

@lnx00
Copy link
Copy Markdown
Author

lnx00 commented Apr 10, 2019

Special colors for each category is a good idea! I'm going to start to implement it today. Did you think about custom ForeColors or BackColors?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants