Skip to content

Comments

Fix #24 (feat) : added the preloader#30

Merged
Om-Thorat merged 6 commits intobsoc-bitbyte:mainfrom
ShirshenduR:Fix#24
Jul 9, 2025
Merged

Fix #24 (feat) : added the preloader#30
Om-Thorat merged 6 commits intobsoc-bitbyte:mainfrom
ShirshenduR:Fix#24

Conversation

@ShirshenduR
Copy link
Contributor

Overview

  1. This PR fixes or fixes part of [Feature Request]: Add the PreLoader after Logging In #24 .
  2. This PR does the following: Adds a responsive preloader page with YDO animation, loading bar, and personalized welcome message with user's name.

Essential Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
  • The PR is made from a branch that's not called "main/master".

Proof that changes are correct

Screen.Recording.2025-07-04.at.5.55.04.PM.mp4

PR Pointers

  • If you need a review or an answer to a question, and don't have permissions to assign people, leave a comment like the following: "{{Question/comment}} @{{reviewer_username}} PTAL".
  • Never force push. If you do, your PR will be closed.
    Please review @Om-Thorat @Zapper9982

@netlify
Copy link

netlify bot commented Jul 4, 2025

Deploy Preview for ydo-bsoc ready!

Name Link
🔨 Latest commit 42d979f
🔍 Latest deploy log https://app.netlify.com/projects/ydo-bsoc/deploys/686b41e1dbfb9b00082430eb
😎 Deploy Preview https://deploy-preview-30--ydo-bsoc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@Zapper9982
Copy link
Collaborator

Can we perhaps keep the same Background gradient as the one on the Landing page

@ShirshenduR
Copy link
Contributor Author

@Zapper9982 I have used gradient background that looked similar to figma we can replace it once our background is ready

@Zapper9982
Copy link
Collaborator

image this is the expected background . According to you files you have created a linear gradient in background , which is not the intended behaviour we are expecting a Image as a background

@ShirshenduR
Copy link
Contributor Author

@Zapper9982 I updated it to use same bg image as landing page

Signed-off-by: Shirshendu R Tripathi <shirsh8924@gmail.com>
Signed-off-by: Shirshendu R Tripathi <shirsh8924@gmail.com>
@ShirshenduR
Copy link
Contributor Author

@Zapper9982 Please check now I have made the changes.

@ShirshenduR ShirshenduR requested a review from Zapper9982 July 4, 2025 13:36
@Zapper9982
Copy link
Collaborator

@ShirshenduR Looks great to me , can you attach a preview video for the final outcome

@ShirshenduR
Copy link
Contributor Author

ShirshenduR commented Jul 4, 2025

Screen.Recording.2025-07-04.at.7.56.01.PM.mov

@Zapper9982 Here is the preview. Is it correct?

@Zapper9982
Copy link
Collaborator

Ahh @ShirshenduR can you change the landing page background to the one you have used perhaps for consistency ?

Signed-off-by: Shirshendu R Tripathi <shirsh8924@gmail.com>
@ShirshenduR ShirshenduR requested a review from Zapper9982 July 5, 2025 15:08
@ShirshenduR
Copy link
Contributor Author

ShirshenduR commented Jul 5, 2025

@Zapper9982 I have changed all backgrounds to same image and I found two bugs one on 404 page its a scaling issue and one on the login page
Screenshot 2025-07-05 at 8 40 09 PM

Screen.Recording.2025-07-05.at.8.44.09.PM.mov

I have changed other backgrounds also.

@Zapper9982
Copy link
Collaborator

@Zapper9982 I have changed all backgrounds to same image and I found two bugs one on 404 page its a scaling issue and one on the login page Screenshot 2025-07-05 at 8 40 09 PM

Screen.Recording.2025-07-05.at.8.44.09.PM.mov

I have changed other backgrounds also.

Hey thanks for looking out can u perhaps open a new issue for the same. and raise a PR

@Zapper9982
Copy link
Collaborator

@ShirshenduR do resolve the merge conflicts too

@ShirshenduR
Copy link
Contributor Author

ShirshenduR commented Jul 7, 2025

@Zapper9982 I have opened the issue and resolved the merge conflicts in this PR. Please assign me the issue and add the labels to this PR.

@Om-Thorat Om-Thorat merged commit 42a0ea6 into bsoc-bitbyte:main Jul 9, 2025
6 checks passed
@ShirshenduR
Copy link
Contributor Author

@Om-Thorat @Zapper9982 please add labels to this pr

@Zapper9982 Zapper9982 added Difficulty : Medium medium level issue BSoC'25 Created for BSoC'25 Frontend labels Jul 9, 2025
SHREESHANTH99 pushed a commit to SHREESHANTH99/YDO that referenced this pull request Jul 10, 2025
* feat: added the preloader

* feat: preloader background updated

* feat: preloader fixed bg and svg

Signed-off-by: Shirshendu R Tripathi <shirsh8924@gmail.com>

* feat: preloader fixed bg and svg

Signed-off-by: Shirshendu R Tripathi <shirsh8924@gmail.com>

* feat: fixed the backgrounds and comments

Signed-off-by: Shirshendu R Tripathi <shirsh8924@gmail.com>

---------

Signed-off-by: Shirshendu R Tripathi <shirsh8924@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BSoC'25 Created for BSoC'25 Difficulty : Medium medium level issue Frontend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants