add new subtypes, detailed benchmarks#91
Closed
gokutheengineer wants to merge 4 commits intobsv-blockchain:masterfrom
Closed
add new subtypes, detailed benchmarks#91gokutheengineer wants to merge 4 commits intobsv-blockchain:masterfrom
gokutheengineer wants to merge 4 commits intobsv-blockchain:masterfrom
Conversation
Contributor
👋 Thanks, @gokutheengineer!This pull request comes from a fork. For security, our CI runs in a restricted mode.
Thanks for contributing to bsv-blockchain/go-tx-map! 🚀 |
|
mrz1836
requested changes
Feb 25, 2026
Collaborator
mrz1836
left a comment
There was a problem hiding this comment.
Linter and pre-commit issues. Please review the CI errors. @gokutheengineer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This pull request introduces comprehensive benchmarking and memory profiling for various hash map implementations used in the project, comparing
dolthub,cockroachdb, Go's native map, andtidwall. It also adds the necessary dependencies for benchmarking, and includes a minor thread-safety improvement. The results are summarized in a new markdown report and detailed output files, providing actionable recommendations for map selection based on performance and memory usage.Benchmarking and Analysis
BENCHMARK_REPORT.md) comparing four hash map implementations across Put, Get, Exists, Delete operations, and memory footprint. The report includes recommendations and key takeaways for map selection.res_put_ops.txt,res_get_ops.txt,res_exists_ops.txt,res_del_ops.txt,res_memory_footprint.txt). [1] [2] [3] [4] [5]Dependency Management
go.modto add indirect dependencies for benchmarking and alternative map implementations:cockroachdb/swiss,klauspost/cpuid/v2,tidwall/hashmap, andzeebo/xxh3.Thread Safety Improvement
SwissMapUint64.Existsmethod to use a read lock (RLock) instead of a write lock (Lock), improving concurrency for read operations.Miscellaneous
tx_map_examples_test.go, likely as a cleanup or to avoid conflicts in test files.These changes provide valuable insights into the trade-offs between speed and memory usage for different map implementations, and improve the thread safety of the codebase.