wire+chaincfg: add signet params#1692
Conversation
Pull Request Test Coverage Report for Build 773968254
💛 - Coveralls |
|
cc @wpaulino |
Roasbeef
left a comment
There was a problem hiding this comment.
How about the ability to configure a signet target at runtime? Otherwise if people want to make their own custom signets (which I think is the whole point?), then they'd need to recompile and distribute their binaries, vs being able to say: "yo use these params to join my signet that has covenants implemented".
|
@Roasbeef I added the changes necessary to connect to a custom signet. I wasn't able to spin one up locally, but I'll test this as soon as I'm successful. |
|
I've verified that syncing a Example for connecting to a custom local signet (using Client: Here's my script I used to spin up my own signet (must run inside the |
|
@Roasbeef PTAL, would be nice to include this in the next |
This commit adds all necessary chain parameters for connecting to the public signet network. Reference: bitcoin/bitcoin#18267
This commit adds the --signet command line flag (or signet config option) for starting btcd in signet mode.
This commit adds the --signet command line flag to the btcctl utility.
Roasbeef
left a comment
There was a problem hiding this comment.
Thanks for making the signet configuration more flexible! I have some things in mind that would be really dope to expose using a new public signet 😈
|
@guggero tried to click on that pastebin link but it's expired, if you recall what it was, can you re-host it somewhere? Thanks! |
Roasbeef
left a comment
There was a problem hiding this comment.
Actually re-visiting the BIP, this doesn't appear to allow creation of a "custom" signet as no new logic to validate the new block commitment nor the challenge signature has been added. Is the intent here just to add a "light" minimally validating signet client in the short term before following up w/ the proper block generation and validation logic?
Roasbeef
left a comment
There was a problem hiding this comment.
Chatted w/ Oliver offline and determined that we'll merge this "light client" functionality, then later follow up with the fully logic needed to produce and verify signet blocks so new public btcd based signets will be possible in the future.
wire+chaincfg: add signet params
This commit adds all necessary chain parameters for connecting to the
public signet network.
Reference: bitcoin/bitcoin#18267
Needed for adding signet support to
lnd.Replaces #1536.
cc @Roasbeef, @cfromknecht.