peer+server: add new config option to optionally disable stall detection#1752
Conversation
Roasbeef
force-pushed
the
config-disable-stall-handler
branch
from
d43ba26 to
361233c
Compare
Pull Request Test Coverage Report for Build 1296745038
💛 - Coveralls |
|
For user friendliness, I think it'd be better if the Fairly sure you wouldn't want this for testnet either.. |
guggero
left a comment
guggero
left a comment
There was a problem hiding this comment.
LGTM, pending @kcalvinalvin's suggestion 🎉
|
I agree with the check to disable this on mainnet. No opinion on testnet. |
|
We definitely need this to fix our itest flakes! I'm seeing this disconnect problem more often now. |
|
Could you rebase this PR so it runs the correct actions? |
|
Hmm, this seems to block |
Roasbeef
force-pushed
the
config-disable-stall-handler
branch
from
361233c to
ef3e88c
Compare
In this commit, we add a new config options that allows one to start `btcd` in an operating mode that disables the stall detection. This can be useful in simnet/regtest integration tests settings where it's important that `btcd` holds on to its possibly sole connection to the only other node in the test harness. A new config flag has been added to gate this behavior, which is off by default.
Roasbeef
force-pushed
the
config-disable-stall-handler
branch
from
ef3e88c to
e98a1a1
Compare
|
@jcvernaleo @kcalvinalvin PTAL Applied that fix, thanks @guggero! |
|
Post merge ACK |
…andler peer+server: add new config option to optionally disable stall detection
6 participants
In this commit, we add a new config options that allows one to start
btcdin an operating mode that disables the stall detection. This canbe useful in simnet/regtest integration tests settings where it's
important that
btcdholds on to its possibly sole connection to theonly other node in the test harness.
A new config flag has been added to gate this behavior, which is off by
default.