Skip to content

mempool: export checkStandardness func#1840

Merged
Roasbeef merged 1 commit into
btcsuite:masterfrom
ellemouton:exportCheckStandardnessFunc
May 26, 2022
Merged

mempool: export checkStandardness func#1840
Roasbeef merged 1 commit into
btcsuite:masterfrom
ellemouton:exportCheckStandardnessFunc

Conversation

@ellemouton
Copy link
Copy Markdown
Contributor

Export checkStandardness func so that it can be used elsewhere

@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 2148913830

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.004%) to 54.135%

Files with Coverage Reduction New Missed Lines %
txscript/taproot.go 2 95.93%
Totals Coverage Status
Change from base Build 2148764512: 0.004%
Covered Lines: 24800
Relevant Lines: 45811

💛 - Coveralls

Copy link
Copy Markdown
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍁

It might also be useful to eventually export some more mempool components as well? So enough to be able to give it a mock UTXO set and apply the normal contextual validation. This might already be possible however. I think maybe we should defer merging this till the lnd PR using the new functionality gets further along so we can consider everything as a whole? No strong feelings in this direction fwiw.

@ellemouton
Copy link
Copy Markdown
Contributor Author

I think maybe we should defer merging this till the lnd PR using the new functionality gets further along so we can consider everything as a whole?

yeah agreed. Just wanted to open this one up so long so that the go.mod in the LND pr is pointing to something visable

@Roasbeef
Copy link
Copy Markdown
Member

We're seeing more instances of this in lnd when users end up creating mega transactions, so I think it's worth landing this, then circling back to see if we can add more contextual validation.

Copy link
Copy Markdown
Member

@jcvernaleo jcvernaleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@Roasbeef Roasbeef merged commit fd7f41c into btcsuite:master May 26, 2022
asheswook pushed a commit to asheswook/btcd that referenced this pull request Apr 2, 2026
…essFunc

mempool: export checkStandardness func
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants