support testmempoolaccept for both bitcoind and btcd#2053
Merged
Conversation
yyforyongyu
force-pushed
the
testmempoolaccept
branch
2 times, most recently
from
aac22d3 to
b4aca59
Compare
Pull Request Test Coverage Report for Build 7526854816
💛 - Coveralls |
Member
I think we can try to map them on the RPC level here? So returning a nice concrete error directly to the caller within the |
Roasbeef
reviewed
Nov 15, 2023
Member
Roasbeef
left a comment
Roasbeef
left a comment
There was a problem hiding this comment.
First pass of the WIP PR, we should also add an itest for the newly exposed command.
yyforyongyu
force-pushed
the
testmempoolaccept
branch
from
b4aca59 to
bbe772a
Compare
4 tasks
yyforyongyu
force-pushed
the
testmempoolaccept
branch
from
bbe772a to
d5f1af5
Compare
yyforyongyu
changed the title
testmempoolaccept for both bitcoind and btcdtestmempoolaccept for both bitcoind and btcd
yyforyongyu
force-pushed
the
testmempoolaccept
branch
2 times, most recently
from
a008686 to
2a23314
Compare
Member
|
cc @ellemouton |
Roasbeef
approved these changes
Dec 19, 2023
| // NOTE: must be performed after buf.Bytes is copied above. | ||
| // | ||
| // TODO(yy): remove it once the above TODO is addressed. | ||
| if err := tx.Deserialize(buf); err != nil { |
Member
There was a problem hiding this comment.
I think I'm missing something here: we just serialized it above, why wouldn't it deserialize here?
Collaborator
Author
There was a problem hiding this comment.
this is because tx.Serialize doesn't do any check to make sure it's a valid tx, one can pass an empty *wire.MsgTx to it and it will decode [0 0 0 0 0 0 0 0 0 0] into the buffer.
yyforyongyu
force-pushed
the
testmempoolaccept
branch
from
2a23314 to
3b15171
Compare
yyforyongyu
force-pushed
the
testmempoolaccept
branch
from
3b15171 to
3845a27
Compare
Member
|
cc @ellemouton (can't req review as is) |
ellemouton
approved these changes
Jan 15, 2024
Contributor
ellemouton
left a comment
ellemouton
left a comment
There was a problem hiding this comment.
Very nice 🔥 Ultra clean 🤩
This commit breaks the `maybeAcceptTransaction` into two parts - the first is reading the mempool to validate the transaction, and the relevant logic has been moved into the new method `checkMempoolAcceptance`. The second part is writing to the mempool, and is kept in the method `maybeAcceptTransaction`.
This commit adds bitcoind version 22.0 and 25.0 to our `BackendVersion` set to handle the `testmempoolaccept` RPC calls. A unit test is added to make sure the parser works as expected.
This commit adds a new interface `TxMempool` which defines how other subsystems interact with `TxPool`.
…laccept` This commit creates a `RejectReasonMap` to map the errors returned from `btcd` to bitcoind's `testmempoolaccept` so the `RejectReason` is unified at the RPC level. To make sure the map keys are unique, the error strings are modified in `btcd`.
Also add the `make tidy-module` copied from `lnd`.
yyforyongyu
force-pushed
the
testmempoolaccept
branch
from
3845a27 to
fbe65bf
Compare
asheswook
pushed a commit
to asheswook/btcd
that referenced
this pull request
Apr 2, 2026
support `testmempoolaccept` for both `bitcoind` and `btcd`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR expands the RPC client with the new method
testmempoolaccept.testmempoolacceptand map them inbtcwallet(orlnd)?