Conversation
add token map generator logic
add dynamic checkpoint submit filter
add feature check for heimdall
add cli for token map
only refactoring optimization
add event id check when processing
opt heimdall logic
ClarkChenc
reviewed
Jul 21, 2023
| cp.Logger.Error("proposal feature-dynamic-checkpoint maxlength is too long", | ||
| "maxLength", maxLength, "MaxCheckpointLength", maxCheckpointLengthParam) | ||
|
|
||
| return true |
Contributor
There was a problem hiding this comment.
What if the end - start + 1 < maxCheckpointLengthParam but maxCheckpointLengthParam < maxLength ?
I wonder should the case always be true?
Contributor
There was a problem hiding this comment.
in case :checkpoint length<=maxCheckpointLengthParam<maxLength
There will no checkpoint to submit when no cross chain tx in chain.
opt log output and complexity
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## develop #55 +/- ##
========================================
Coverage 60.29% 60.29%
========================================
Files 52 52
Lines 4423 4423
========================================
Hits 2667 2667
Misses 1519 1519
Partials 237 237 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
modify BlockDiff to 25
ClarkChenc
force-pushed
the
opt_checkpoint_submission
branch
from
29c386b to
09a9601
Compare
modify TokenMapProcessor to singleton
add some log
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add dynamic checkpoints submission mechanism to delivery.