add(core): eth finalized block#67
Merged
bladehan1 merged 1 commit intobttcprotocol:developfrom Oct 13, 2023
Merged
Conversation
bladehan1
force-pushed
the
fea-eth-finalized
branch
2 times, most recently
from
b590633 to
98d8e4f
Compare
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## develop #67 +/- ##
===========================================
+ Coverage 60.29% 60.33% +0.03%
===========================================
Files 52 52
Lines 4423 4427 +4
===========================================
+ Hits 2667 2671 +4
Misses 1519 1519
Partials 237 237
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bladehan1
force-pushed
the
fea-eth-finalized
branch
2 times, most recently
from
0ede86f to
e727c81
Compare
bladehan1
force-pushed
the
fea-eth-finalized
branch
from
e727c81 to
500dabc
Compare
kuny0707
approved these changes
Aug 30, 2023
bladehan1
force-pushed
the
fea-eth-finalized
branch
from
500dabc to
f694774
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add query eth finalized block to prevent transaction verification error when eth is forked.
Why are these changes required?
The eth2.0 finalized block may be more than 64 blocks away from the head block. At this time, it is not safe to use the original method to verify transactions on the eth chain.
This PR has been tested by:
Unit Tests
Manual Testing
Follow up
Extra details