Skip to content

add noAckValidator Check#83

Merged
kuny0707 merged 1 commit intobttcprotocol:developfrom
bladehan1:noAckCheck
May 9, 2024
Merged

add noAckValidator Check#83
kuny0707 merged 1 commit intobttcprotocol:developfrom
bladehan1:noAckCheck

Conversation

@bladehan1
Copy link
Copy Markdown
Contributor

@bladehan1 bladehan1 commented Apr 23, 2024

Description

Add check for noAck msg.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Verification noAck message must come from validator

Checklist

  • I have added at least 1 reviewer to this PR
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Cross repository changes

  • This PR requires changes to delivery
    • In case link the PR here:

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet

Manual tests

Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@bladehan1 bladehan1 changed the title chg: add noAckValidator Check add noAckValidator Check May 6, 2024
@kuny0707 kuny0707 merged commit 0ab4758 into bttcprotocol:develop May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants