Skip to content

fix: error handling in _resolve_final_data function #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frostming merged 1 commit into from
Apr 16, 2026
Merged

fix: error handling in _resolve_final_data function #169

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/bub/builtin/agent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
LLM,
AsyncStreamEvents,
AsyncTapeStore,
RepublicError,
StreamEvent,
StreamState,
TapeContext,
Expand Down Expand Up @@ -229,7 +230,7 @@ async def _stream_events_with_auto_handoff(
},
)
elif event.kind == "final":
outcome = _resolve_tool_auto_result(event.data)
outcome = _resolve_final_data(event.data, output.error)

state.error = output.error
state.usage = output.usage
Expand Down Expand Up @@ -363,12 +364,13 @@ class _ToolAutoOutcome:
error: str = ""


def _resolve_tool_auto_result(final_data: dict[str, Any]) -> _ToolAutoOutcome:
def _resolve_final_data(final_data: dict[str, Any], error: RepublicError | None) -> _ToolAutoOutcome:
if final_data.get("tool_calls") or final_data.get("tool_results"):
return _ToolAutoOutcome(kind="continue")
if (text := final_data.get("text")) is not None:
return _ToolAutoOutcome(kind="text", text=text)
return _ToolAutoOutcome(kind="error", error="unknown error")
error_message = error.message if error else ""
return _ToolAutoOutcome(kind="error", error=error_message or "unknown error")


def _build_llm(settings: AgentSettings, tape_store: AsyncTapeStore, tape_context: TapeContext) -> LLM:
Expand Down
Loading