Adv fizzbuzz#2
Open
buckleys78 wants to merge 4 commits intomasterfrom
Open
Conversation
There was a problem hiding this comment.
Very interesting syntax, nice and compact for the actual method. Your code is fine for this submission, but here's some food for thought: what if the user of this program can't code or doesn't know what a hash is? How can you make this even friendlier for the user? The hash argument sent to the method could get ungodly long also if you have a long list of divisors.
Congrats on delivering a nice function!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updated to handle any number of key/value pairs.