Skip to content

Avoid overwriting files that don't actually change in buf format#3058

Merged
jhump merged 3 commits intomainfrom
jh/bufformat-doesnt-write-on-noop
Jun 10, 2024
Merged

Avoid overwriting files that don't actually change in buf format#3058
jhump merged 3 commits intomainfrom
jh/bufformat-doesnt-write-on-noop

Conversation

@jhump
Copy link
Copy Markdown
Member

@jhump jhump commented Jun 7, 2024

This avoids file system change notifications for files that don't actually change. See thread in Public Slack for more context: https://bufbuild.slack.com/archives/CRZ680FUH/p1717784544902049

@jhump jhump requested a review from bufdev June 7, 2024 21:46
Copy link
Copy Markdown
Member

@bufdev bufdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with two nits

@jhump jhump merged commit 2c67244 into main Jun 10, 2024
@jhump jhump deleted the jh/bufformat-doesnt-write-on-noop branch June 10, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants