Skip to content

Remove nrwl/nx-set-shas from CI#2424

Merged
stefanvanburen merged 7 commits intomainfrom
jfigueroa/remove-nx-set-shas
Apr 23, 2026
Merged

Remove nrwl/nx-set-shas from CI#2424
stefanvanburen merged 7 commits intomainfrom
jfigueroa/remove-nx-set-shas

Conversation

@unmultimedio
Copy link
Copy Markdown
Contributor

@unmultimedio unmultimedio commented Apr 22, 2026

Summary

  • Removes the nrwl/nx-set-shas action from the CI workflow
  • Adds a new last-successful-commit command (using appcmd) that calls the GitHub Actions API directly to find the last successful run SHA for a given workflow and branch
  • Updates the CI step to use last-successful-commit + changed-plugins instead of relying on the action output

@unmultimedio unmultimedio requested a review from pkwarren April 22, 2026 18:30
@unmultimedio unmultimedio changed the base branch from main to jfigueroa/remove-nrwl-nx-set-shas April 22, 2026 18:32
@unmultimedio unmultimedio changed the title Remove nrwl/nx-set-shas from CI Remove nrwl/nx-set-shas from CI Apr 22, 2026

func run(ctx context.Context, container appext.Container, f *flags) error {
client := release.NewClient()
runs, _, err := client.GitHub.Actions.ListWorkflowRunsByFileName(
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of a new go command, could we use the gh CLI to accomplish the same thing:

gh api "repos/${{ github.repository }}/actions/workflows/ci.yml/runs?branch=${{ github.ref_name }}&status=success&per_page=1" --jq '.workflow_runs[0].head_sha'`

Base automatically changed from jfigueroa/remove-nrwl-nx-set-shas to main April 22, 2026 19:31
@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@stefanvanburen stefanvanburen merged commit ae645c8 into main Apr 23, 2026
2 of 3 checks passed
@stefanvanburen stefanvanburen deleted the jfigueroa/remove-nx-set-shas branch April 23, 2026 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants