Merged
Conversation
kiriappeee
approved these changes
Apr 1, 2020
Member
kiriappeee
left a comment
There was a problem hiding this comment.
Tested. Looks great to me @djfarrelly . Thanks for getting this up 👍
Member
|
Quick aside, this isn't necessary for this PR. Might be good to specify minimum versions of node for this package. |
This ensures the -V version flag always returns the correct version without requiring the developer to manually update this.
Contributor
Author
|
2 great ideas @kiriappeee!
@kiriappeee, do you have an npm username? I want to add you to our |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The binary executable is great, but using
npmis an easier way to consume, upgrade and publish updates to this package. Package on npmThis also closes #3.
Background
The binary method felt the most usable when this package was written in golang and we didn't want to use npm as a delivery method. We used
pkgbefore for other binaries (buffer-dev) because we wanted them to be more easily usable for non-developers, but since this is a developer tool, I think it's ok to assume everyone on the engineering team has node and npm installed 😄Review
Hey @kiriappeee, I was thinking of making another addition to this CLI and thought of this idea. We could continue to build + distribute the binary, but this might be simpler for folks on the team to download the binary off of Github and move it into their PATH. What do you think?