chore: upgrade zip 7.x to 8.0 and tempfile to 3.25#60
Merged
Conversation
zip 8.0 removes deprecated DateTime::to_time() method. Replace with manual civil-date-to-unix-timestamp conversion using Howard Hinnant's days_from_civil algorithm, eliminating the transitive dependency on the time crate for this codepath.
github-actions
bot
added
core
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #60 +/- ##
==========================================
+ Coverage 90.25% 90.31% +0.05%
==========================================
Files 62 58 -4
Lines 10358 10191 -167
==========================================
- Hits 9349 9204 -145
+ Misses 1009 987 -22
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Replace hand-rolled days_from_civil with time::PrimitiveDateTime via TryFrom<zip::DateTime>, which zip 8.0 provides behind the "time" feature flag. Add time as a direct workspace dependency (was already transitive via zip).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
zipfrom 7.x to 8.0 (breaking API change:DateTime::to_time()removed)tempfilefrom 3.24 to 3.25DateTime::to_time()withtime::PrimitiveDateTimeconversion viaTryFrom<zip::DateTime>timeas direct workspace dependency (previously transitive viazip)Test plan
cargo nextest run)cargo clippy -- -D warnings)