Skip to content

fix: remove memory leak when processing gocv images #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
import-benjamin merged 1 commit into from
Aug 31, 2025
Merged

fix: remove memory leak when processing gocv images #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions internal/adapter/http/controls/controls.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ func StreamVideoHandler(w http.ResponseWriter, r *http.Request) {
if err != nil {
http.Error(w, "Error capturing image: %v", http.StatusServiceUnavailable)
}
// defer img.Close()

resizedFrame := gocv.NewMat()

Expand All @@ -73,7 +72,10 @@ func StreamVideoHandler(w http.ResponseWriter, r *http.Request) {
if _, err := partWriter.Write(buf.GetBytes()); err != nil {
log.Println("Error while processing buffer")
}


buf.Close()
resizedFrame.Close()
img.Close()
// we want to record around 10 fps
// this mean every second send 10 images
// Let's assume reading, encoding and writing do not consume any resources
Expand Down