Enhance iterator equality test coverage

[Copilot]

The IteratorsFromDifferentBuffersAreNotEqual test only verified iterator inequality between empty buffers from different sources, missing key equality semantics.

Changes

• Added test cases for iterator self-equality (begin() == begin() for same buffer)
• Added test cases for iterator inequality within same buffer (begin() != end() when non-empty)
• Added test cases for iterator inequality across buffers at same logical position after insertions

TEST(RingBufferTest, IteratorsFromDifferentBuffersAreNotEqual) {
    ring_buffer<int, 3> b1;
    ring_buffer<int, 3> b2;

    // Iterators from different buffers should not be equal
    EXPECT_NE(b1.cbegin(), b2.cbegin());
    
    // Add elements to both buffers
    b1.push_back(1);
    b1.push_back(2);
    b2.push_back(1);
    b2.push_back(2);
    
    // Iterators at the same logical position from different buffers should still be unequal
    EXPECT_NE(b1.cbegin(), b2.cbegin());
    EXPECT_NE(b1.cend(), b2.cend());
    
    // Iterators from the same buffer at the same position should be equal
    EXPECT_EQ(b1.cbegin(), b1.cbegin());
    EXPECT_EQ(b1.cend(), b1.cend());
    
    // begin() and end() from the same buffer should be different when not empty
    EXPECT_NE(b1.cbegin(), b1.cend());
    EXPECT_NE(b2.cbegin(), b2.cend());
}

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

---

Important

Enhance iterator equality test coverage in RingBufferTest by adding new test cases for self-equality, inequality within the same buffer, and inequality across different buffers.

• Tests:
  • Enhance IteratorsFromDifferentBuffersAreNotEqual in test_main.cpp.
  • Add iterator self-equality tests (begin() == begin()) for the same buffer.
  • Add iterator inequality tests (begin() != end()) within the same buffer when non-empty.
  • Add iterator inequality tests across different buffers at the same logical position after insertions.

^{This description was created by for 55aec70. You can customize this summary. It will automatically update as commits are pushed.}

[coderabbitai]

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

This PR enhances test coverage for iterator equality semantics in the RingBufferTest::IteratorsFromDifferentBuffersAreNotEqual test. The original test only verified inequality between empty iterators from different buffers, lacking comprehensive validation of equality behavior.

Changes:

• Extended iterator inequality tests to include non-empty buffers with identical content
• Added iterator self-equality tests for begin() and end() from the same buffer
• Added verification that begin() != end() for non-empty buffers

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File	Description
test_main.cpp	Expanded iterator equality test with additional assertions covering self-equality, cross-buffer inequality with data, and begin/end inequality
_codeql_detected_source_root	Added CodeQL configuration file
.gitignore	Added CodeQL build directory to ignored files

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[ellipsis-dev]

Important

Looks good to me! 👍

Reviewed everything up to 55aec70 in 45 seconds. Click for details.

• Reviewed 39 lines of code in 2 files
• Skipped 1 files when reviewing.
• Skipped posting 6 draft comments. View those below.
• Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

1. _codeql_detected_source_root:1

• Draft comment:
  New source root marker file added; ensure this is intentional for CodeQL configuration.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50% None

2. test_main.cpp:122

• Draft comment:
  Good initial check ensuring iterators from different buffers are unequal, even when empty.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50% None

3. test_main.cpp:125

• Draft comment:
  Adding elements to both buffers properly expands test coverage for non-empty states.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50% None

4. test_main.cpp:131

• Draft comment:
  Verifies that iterators at equivalent logical positions from different buffers remain unequal.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50% None

5. test_main.cpp:135

• Draft comment:
  Confirms self-comparison of iterators from the same buffer yields equality, as expected.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50% None

6. test_main.cpp:139

• Draft comment:
  Checks that begin() and end() iterators in non-empty buffers are not equal, ensuring proper boundary semantics.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50% None

Workflow ID: wflow_1OmAhf6meWudC0nk

^{You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}