Couldn't download output files when secure parameter is used

[pulpo]

When I try to use a secure parameter, for example for a password, the download file dialog is not displayed.

    {
      "name": "Password",
      "param": "-p",
      "type": "text", 
      "secure": "true"
    },

If I change the secureto false, after the execution the dialog is displayed. In both cases the temp/resultFiles folder is created.

[bugy]

Hi @pulpo, thanks for reporting. Does the filename depend on the secure parameter or match it somehow?

[pulpo]

Hi @bugy. The filename doesn't depends on the secure parameter. I made an script that does nothing but showing a hello message, and when I add a secure parameter I reproduce the problem. I tested it against stable and dev tags (from the docker image) with the same results.

{
  "name": "Download file",
  "output_files": [
    "/tmp/final.json"
  ],
  "working_directory":"/app/scripts",
  "script_path": "hello.sh",
  "parameters": [
    {
      "name": "Bla",
      "param": "-p",
      "type": "text",
      "secure": "true" 
    }
  ]

Changing the secure's value or removing parameters shows me the download dialog.

[bugy]

Thanks a lot for the nice description and configuration examples. I'll have a look

[bugy]

I reproduced it locally, looks like a race condition for me (sometimes the download file is still shown). Will work on the fix in the nearest days

[bugy]

Fixed. Should work now.

Thanks again for reporting!

[pulpo]

I can confirm that it's fixed, tested on the dev branch. Thanks for your great work!