Conversation
bugy
left a comment
bugy
left a comment
There was a problem hiding this comment.
Hi @gpsinghsandhu thanks for your PR! And sorry for super slow response :(
In general, the idea is good, but I would like to have it to be more Vue/reactive style, with having computed properties, instead of data+watch.
bugy
left a comment
bugy
left a comment
There was a problem hiding this comment.
Hi, I finally found some time and checked the behaviour locally, it would be great to improve the button behaviour and use default materialize styles for the input field :)
| }, | ||
|
|
||
| searchIconClickHandler() { | ||
| if (this.isClearSearchButton) { |
There was a problem hiding this comment.
I would suggest to check searchText instead
Also, if searchText is empty, probably we could focus the field, when the button is clicked
There was a problem hiding this comment.
Done.
I believe we should focus the field in any case (whether clearing or clicking search button).
Co-authored-by: Iaroslav Shepilov <buggygm@gmail.com>
2 participants
A very simple implementation of search functionality in history. Search is implemented client-side. This currently searches only on 'user' and 'script' for the given search text. Suggestions are welcome.
Also fixed vue warning regarding mutating props. See commit - cdf8352
@bugy Need input on where to add this in documentation.
Note: I did not use the current 'SearchPanel' component, since it seemed very specific to the script search.
