Skip to content

Quick fixes from Bazel-ification #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
m3rcuriel wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Quick fixes from Bazel-ification #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23265a3
Fix system-style includes
m3rcuriel Jul 4, 2019
46d6dbc
Catch by reference
m3rcuriel Jul 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions camera/camera_manager.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ std::string config_search_location() {
std::optional<YAML::Node> read_YAML(const std::string& filepath) {
try {
return YAML::LoadFile(filepath);
} catch (YAML::BadFile e) {
} catch (YAML::BadFile &e) {
const std::string err = std::string("Could not find YAML file ") + filepath;
throw std::runtime_error(err);
}
Expand Down Expand Up @@ -94,4 +94,4 @@ Camera CameraManager::get_camera(const std::string& serial_number) const {
}
return camera_from_serial_.at(serial_number);
}
} // namespace jet
} // namespace jet
2 changes: 1 addition & 1 deletion embedded/servo_driver/servo_driver.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ ServoDriver::ServoDriver(const Config& config) {
calibrated_max_ = config["calibrated_max"].as<float>();
servo_index_ = config["index"].as<int>();
assert(servo_index_ >= 0);
} catch (YAML::BadFile e) {
} catch (YAML::BadFile &e) {
std::string err = std::string("Could not find YAML file ");
throw std::runtime_error(err);
}
Expand Down
2 changes: 1 addition & 1 deletion embedded/servo_testing/manual_servo_input_bq.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#pragma once

#include <infrastructure/balsa_queue/balsa_queue.hh>
#include "infrastructure/balsa_queue/balsa_queue.hh"
#include "embedded/servo_bq/servo_balsaq.hh"
#include "embedded/servo_bq/set_servo_message.hh"
#include "embedded/servo_driver/servo_driver.hh"
Expand Down
2 changes: 1 addition & 1 deletion infrastructure/balsa_queue/bq_main_macro.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ void signal_handler(int s) {
if (argc > 1) { \
try { \
config = YAML::LoadFile(argv[1]); \
} catch (YAML::BadFile e) { \
} catch (YAML::BadFile &e) { \
std::cerr << "Could not find YAML file " << std::endl; \
config = YAML::Node(); \
} \
Expand Down
2 changes: 1 addition & 1 deletion infrastructure/comms/subscriber.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#pragma once

#include <infrastructure/time/duration.hh>
#include "infrastructure/time/duration.hh"
#include "infrastructure/comms/schemas/message.hh"

#include <memory>
Expand Down
2 changes: 1 addition & 1 deletion infrastructure/comms/tests/pub_sub_demo_bqs/publisher_demo_bq.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#include <infrastructure/balsa_queue/balsa_queue.hh>
#include "infrastructure/balsa_queue/balsa_queue.hh"

namespace jet {

Expand Down
2 changes: 1 addition & 1 deletion infrastructure/comms/tests/pub_sub_demo_bqs/subscriber_demo_bq.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#include <infrastructure/balsa_queue/balsa_queue.hh>
#include "infrastructure/balsa_queue/balsa_queue.hh"

namespace jet {

Expand Down
2 changes: 1 addition & 1 deletion infrastructure/engine/turbine_interface_bq.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#pragma once

#include <infrastructure/balsa_queue/balsa_queue.hh>
#include "infrastructure/balsa_queue/balsa_queue.hh"

#include "infrastructure/engine/jetcat_turbine.hh"
#include "infrastructure/gonogo/gonogo_message.hh"
Expand Down
2 changes: 1 addition & 1 deletion infrastructure/engine/turbine_monitor_utility.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#include <infrastructure/balsa_queue/balsa_queue.hh>
#include "infrastructure/balsa_queue/balsa_queue.hh"

namespace jet {

Expand Down
2 changes: 1 addition & 1 deletion infrastructure/time/timesync_bq/timesync_master_bq.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#pragma once

#include <infrastructure/balsa_queue/balsa_queue.hh>
#include "infrastructure/balsa_queue/balsa_queue.hh"

namespace jet {

Expand Down
2 changes: 1 addition & 1 deletion vision/fiducial_detection_balsaq.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#include <infrastructure/balsa_queue/balsa_queue.hh>
#include "infrastructure/balsa_queue/balsa_queue.hh"
//%deps(opencv)
#include <opencv2/aruco.hpp>
#include <opencv2/opencv.hpp>
Expand Down