Skip to content

Replace environment bootstrap with direnv #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
khaledhassan wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Replace environment bootstrap with direnv #169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07debe7
add .envrc and instructions in readme.md
khaledhassan Jun 19, 2023
94e5b8b
add pointer to direnv builtins
khaledhassan Jun 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .envrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
# direnv's .envrc works with bash-like export and unset, etc.
# but see `man direnv-stdlib` or <https://direnv.net/man/direnv-stdlib.1.html> for built-in functions
PATH_add infrastructure/scripts

4 changes: 4 additions & 0 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,10 @@ git pull --rebase origin master
./infrastructure/scripts/environment_bootstrap.sh
```
Copy link
Author

@khaledhassan khaledhassan Jun 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this looks good, better to remove the environment_bootstrap.sh script and instructions so as to not maintain 2 sets of bootstrap scripts? (Then again, not a huge burden as the environment_bootstrap.sh has not changed much 😄 )

Copy link
Author

@khaledhassan khaledhassan Sep 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sentree / @benkroop - should we remove environment_bootstrap.sh or keep it around?


### Using `direnv`

1. Set up `direnv` ([install the binary/package](https://direnv.net/docs/installation.html) + [hook into your shell](https://direnv.net/docs/hook.html)).
2. Run `direnv allow` inside your repo. `direnv` should complain about being blocked until you do this.

# How to get the Docker image

Expand Down