Update to tests to validate generated pipeline using pipeline upload … #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omehegan
requested changes
Dec 16, 2025
Comment on lines
+575
to
+590
|
|
||
| // --- New: validate generated pipeline with buildkite-agent dry-run --- | ||
| if _, err := exec.LookPath("buildkite-agent"); err == nil { | ||
| cmd := exec.Command( | ||
| "buildkite-agent", | ||
| "pipeline", "upload", | ||
| pipeline.Name(), | ||
| "--dry-run", | ||
| "--agent-access-token", "dummy", | ||
| ) | ||
| out, err := cmd.CombinedOutput() | ||
| t.Log(string(out)) | ||
| require.NoError(t, err, "Buildkite rejected generated YAML") | ||
| } else { | ||
| t.Log("buildkite-agent not installed; skipping dry-run validation") | ||
| } |
There was a problem hiding this comment.
This block is repeated in each test function. I would suggest creating a helper function that does this, and then just calling that from each test. That function could also potentially cover the case where you are using realAgent instead of buildkite-agent and then those other two tests can it as well. That makes the code easier to read and maintain :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to tests to validate generated pipeline using pipeline upload dry run command