Skip to content

Conversation

@DrJosh9000
Copy link
Contributor

@DrJosh9000 DrJosh9000 commented Aug 22, 2024

Description

Ensure that, when removing all files and directories for a cleanup, that directories with weird permissions (e.g. lacking execute bit) are cleaned up.

Context

#2941

Changes

  • Add hardRemoveAll helper function that tests for permissions problems after failing to os.RemoveAll, in a loop
  • Replace some calls to os.RemoveAll with a call to hardRemoveAll

Testing

  • Tests have run locally (with go test ./...). Buildkite employees may check this if the pipeline has run automatically.
  • Code is formatted (with go fmt ./...)

@DrJosh9000 DrJosh9000 force-pushed the remove-all-harder branch 3 times, most recently from bbd80c1 to 0f15b75 Compare August 22, 2024 08:14
@DrJosh9000 DrJosh9000 marked this pull request as ready for review July 31, 2025 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants