Upgrade to AWS Go SDK v2 #3554
Merged
Upgrade to AWS Go SDK v2 #3554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrJosh9000
force-pushed
the
pb-861-aws-sdk-go-v2
branch
3 times, most recently
from
f06ea0c to
1e335e7
Compare
DrJosh9000
force-pushed
the
pb-861-aws-sdk-go-v2
branch
5 times, most recently
from
0e6311f to
b1d6e9c
Compare
wolfeidau
reviewed
Oct 29, 2025
Member
wolfeidau
left a comment
wolfeidau
left a comment
There was a problem hiding this comment.
@DrJosh9000 you may want to remove this internal/awslib/.DS_Store
DrJosh9000
force-pushed
the
pb-861-aws-sdk-go-v2
branch
3 times, most recently
from
51ad6c9 to
51faf87
Compare
wolfeidau
requested changes
Nov 3, 2025
Member
wolfeidau
left a comment
wolfeidau
left a comment
There was a problem hiding this comment.
Just a few small things and questions.
DrJosh9000
force-pushed
the
pb-861-aws-sdk-go-v2
branch
from
51faf87 to
6a5f7ce
Compare
DrJosh9000
force-pushed
the
pb-861-aws-sdk-go-v2
branch
from
6a5f7ce to
2a95448
Compare
moskyb
approved these changes
Nov 4, 2025
Contributor
moskyb
left a comment
moskyb
left a comment
There was a problem hiding this comment.
awesome stuff, this is really fiddly work and it looks like you've done an awesome job.
This was referenced Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade to the supported v2 of the AWS Go SDK (from v1, which is unsupported).
Context
https://linear.app/buildkite/issue/PB-861/update-to-aws-go-sdk-v2
Fixes #3533
Closes #3559
Changes
Find v2 equivalents of v1 functionality. This is mostly fine but not always possible, particularly
NewChainCredentials. Since we should be using a more standard approach to authenticating to AWS anyway (see #3559), I've changed the way that part works to be similar to #3559.Testing
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go fmt ./...)Disclosures / Credits
No AI here