Skip to content

Conversation

@moskyb
Copy link
Contributor

@moskyb moskyb commented Nov 7, 2025

Description

We're currently building a feature where agents (and the jobs running on them) will be able to decide the "scope" for an annotation — ie, whether it's an annotation on the build (the current status quo), or an annotation on a particular job (new and shiny!).

This PR adds a flag to the agent to let callers decide the scope for their annotation. They can use --scope build (or omit the flag entirely) to scope to a build, or use --scope job to display their annotation on a job.

Context

PB-899

Testing

  • Tests have run locally (with go test ./...). Buildkite employees may check this if the pipeline has run automatically.
  • Code is formatted (with go fmt ./...)

Disclosures / Credits

It's all me, baby.

@moskyb moskyb requested a review from mitchbne November 7, 2025 02:28
@moskyb moskyb marked this pull request as ready for review November 7, 2025 02:32
The idea is that users can choose to either annotate the build (the default) or the job, which will affect where the annotation is displayed in the buildkite UI
Copy link
Contributor

@SorchaAbel SorchaAbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one Benno!

@moskyb moskyb merged commit a029c6f into main Nov 12, 2025
1 check passed
@moskyb moskyb deleted the annotation-scope branch November 12, 2025 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants