Skip ticker after running job #3571
Merged
+12
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catkins
reviewed
Nov 10, 2025
| // Do the ping immediately so we reduce the chances our agent is assigned a job | ||
| pingTicker.Reset(pingInterval) | ||
| continue | ||
| } |
Contributor
There was a problem hiding this comment.
hmm looks like this is at least load bearing to some tests currently, so we'll need to rework that little bit
Contributor
Author
There was a problem hiding this comment.
I think I figured it out
DrJosh9000
force-pushed
the
skip-ticker-after-job
branch
from
108ab1f to
7501aff
Compare
catkins
approved these changes
Nov 10, 2025
Contributor
|
Thanks @DrJosh9000 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the ping loop, skip waiting on the
pingTickerwhen a job has just run. When a job has just run, the only wait will be the jitter.Context
Prior to rearranging and introducing jitter, the first thing the ping loop did was always to ping.
continue(implied or explicit) thus led to an immediate ping. Per the comment near the end of the loop (#1567) we want to skip the ticker and ping immediately, but in exchange, wait the full ping interval the next time.After rearranging and introducing jitter, the first thing the ping loop does is wait for the ticker, then the jitter. But the
pingTicker.Resetcall after running a job was written with the expectation that a ping would happen immediately. In the new arrangement, it instead causes the loop to wait the full ping interval first.Changes
firstchannel toskipTickerskipTickerwhen a job has just runTesting
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go fmt ./...)Disclosures / Credits
Good old fashioned wetware