Add Prometheus /metrics handler and some basic metrics #3576
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
More ways to look at what an agent is doing! Here are some metrics geared towards monitoring long-lived agents: agent workers running, pings, jobs, and log chunk uploads, plus all the default Go runtime metrics that the library creates.
Agent-specific metrics:
buildkite_agent_jobs_ended_totalbuildkite_agent_jobs_started_totalbuildkite_agent_logs_bytes_uploaded_totalbuildkite_agent_logs_bytes_uploads_errored_totalbuildkite_agent_logs_chunk_uploads_errored_totalbuildkite_agent_logs_chunks_uploaded_totalbuildkite_agent_logs_upload_duration_seconds_totalbuildkite_agent_pings_actions_totalbuildkite_agent_pings_duration_seconds_totalbuildkite_agent_pings_errors_totalbuildkite_agent_pings_sent_totalbuildkite_agent_pings_wait_duration_seconds_totalbuildkite_agent_workers_ended_totalbuildkite_agent_workers_started_totalContext
https://linear.app/buildkite/issue/PB-920
Changes
promhttp.Handler()to the health-check server mux at the standard path,/metrics.Testing
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go fmt ./...)Disclosures / Credits
I enjoy this stuff.