Fix idle tracking for agents that never received jobs #3579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #3570 idle logic has changed and `idleMon.markIdle` would get only triggered via `AcceptAndRunJob()`. Agents that never received a job wouldn't be marked as idle.
Contributor
|
Just checking, this is deliberately a behaviour change, not just a fix? As far as I can tell, disconnect-after-idle-timeout has until now not timed out agents that haven't yet run a job? |
Contributor
|
Actually, you're right, it seems that it used to set the |
This was referenced Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #3570 idle logic has changed and
idleMon.markIdlewould get only triggered viaAcceptAndRunJob().Agents that never received a job wouldn't be marked as idle.
Context
Issue discovered in buildkite/elastic-ci-stack-for-aws#1652 where the test stacks couldn't be destroyed.
I found out that a single instance would prevent ASG from being destroyed.
I tested agent 3.112.0 on a separate stack and could confirm this behavior.
Agents that received jobs were terminated properly, while agents that never received job would never get marked as idle, handing indefinitely (or until job got assigned to it).
Changes
Testing
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go fmt ./...)I tested build 11168 of the agent on Elastic CI Stack for AWS instance.
It now disconnects immediately when idle, following my agent's configuration.
Disclosures / Credits
I did not use AI tools at all.