Fetch and compare job logs #3606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhming0
approved these changes
Dec 3, 2025
Contributor
zhming0
left a comment
zhming0
left a comment
There was a problem hiding this comment.
Looks good. I have a suggestion. It's not strictly blocking so I will approve it.
internal/e2e/basic_test.go
Outdated
Comment on lines
31
to
33
| if err != nil { | ||
| t.Errorf("tc.fetchLogs() error = %v", err) | ||
| } |
Contributor
There was a problem hiding this comment.
this error handling and the waitForBuild error handling can all happen in the callee side I think, I don't think they will ever be useful on caller side?
Since we have a t *testing.T available, we can effectively "throw" error from callee side.
Contributor
Author
There was a problem hiding this comment.
That's probably true. I'm not sure we'll need a case where they can fail, so I'll move that.
DrJosh9000
force-pushed
the
pb-990-add-mechanism-to-read-job-logs
branch
3 times, most recently
from
abe178a to
b585aa2
Compare
DrJosh9000
force-pushed
the
pb-990-add-mechanism-to-read-job-logs
branch
from
b585aa2 to
3761685
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add ability to fetch job logs to the E2E test helpers, and show that it works in the basic E2E test.
Context
https://linear.app/buildkite/issue/PB-990/add-mechanism-to-read-job-logs
Changes
Per Description.
Testing
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go tool gofumpt -extra -w .)Disclosures / Credits
Some bits copied from https://github.com/buildkite/agent-stack-k8s.