feat: add support for concurrent save and restore operations #3627
+165
−63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This may add a bit of contention but will help with situations where there are many small, sub 1gb caches. I have followed the prevailing style with the concurrency implementation.
CerealBoy
approved these changes
Dec 11, 2025
Contributor
CerealBoy
left a comment
CerealBoy
left a comment
There was a problem hiding this comment.
Would it be a good idea to have a couple of extra test cases, specifically for values like 0 and 100 / having many blobs?
Otherwise LGTM 🚀 🚀
Member
Author
|
Yeah I will add more testing once things have solidified API wise. |
wolfeidau
deleted the
feat_update_cache_to_support_concurrent_save_restore
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This may add a bit of contention but will help with situations where there are many small, sub 1gb caches.
I have followed the prevailing style with the concurrency implementation.
Context
https://linear.app/buildkite/issue/MDC-822/add-support-for-concurrent-save-and-restore-of-caches-in-the-buildkite
Changes
Adds a new option to cache CLI operations and some logic to save and restore to support concurrent operations.
Testing
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go tool gofumpt -extra -w .)Updated tests.
Disclosures / Credits
AMP Code was used to review concurrency options and draft this change, and update tests, then I adjusted a few things.