PB-1007: add e2e test for gcs artifact upload/download #3633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrJosh9000
approved these changes
Dec 14, 2025
Comment on lines
19
to
20
| - export BUILDKITE_GS_APPLICATION_CREDENTIALS_JSON="$$GCP_E2E_TEST_CREDENTIALS_JSON" | ||
| - {{ .buildkite_agent_binary }} artifact download artifact.txt . && if [[ $(cat artifact.txt) == "hello world" ]]; then exit 0; else exit 1; fi |
Contributor
There was a problem hiding this comment.
This comment probably applies to the other artifact test cases, but perhaps we can simplify by using set -e:
Suggested change
| - export BUILDKITE_GS_APPLICATION_CREDENTIALS_JSON="$$GCP_E2E_TEST_CREDENTIALS_JSON" | |
| - {{ .buildkite_agent_binary }} artifact download artifact.txt . && if [[ $(cat artifact.txt) == "hello world" ]]; then exit 0; else exit 1; fi | |
| - set -e | |
| - export BUILDKITE_GS_APPLICATION_CREDENTIALS_JSON="$$GCP_E2E_TEST_CREDENTIALS_JSON" | |
| - {{ .buildkite_agent_binary }} artifact download artifact.txt . | |
| - [[ $(cat artifact.txt) == "hello world" ]] |
Contributor
Author
There was a problem hiding this comment.
For some reason I don't quite understand, our agent does not like - [[ $(cat artifact.txt) == "hello world" ]] being the last line, it fails with 127 every time.
I don't think I have enough time to debug this today so I will merge the slightly verbose version first.
zhming0
force-pushed
the
ming/pb-1007
branch
from
f7838aa to
c8809b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
E2E Test for GCS artifact upload/download
Context
PB-1007
Testing
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go tool gofumpt -extra -w .)Disclosures / Credits
Human