Try to avoid overriding BUILDKITE_PLUGINS_ALWAYS_CLONE_FRESH with false #3644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhming0
approved these changes
Dec 17, 2025
| // Allow BUILDKITE_PLUGINS_ALWAYS_CLONE_FRESH to be enabled either by config | ||
| // or by pipeline/step env. | ||
| if r.conf.AgentConfiguration.PluginsAlwaysCloneFresh { | ||
| setEnv("BUILDKITE_PLUGINS_ALWAYS_CLONE_FRESH", "true") |
Contributor
There was a problem hiding this comment.
I wonder if we need a setEnvOnlyTrue function?
Contributor
Author
There was a problem hiding this comment.
Maybe! Such a cleanup can probably go in another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If
BUILDKITE_PLUGINS_ALWAYS_CLONE_FRESHis enabled via pipeline or step env, the agent should continue to respect that, rather than overriding with a config option that defaults tofalse. If the option is set to true, then any other value will still be overridden.Context
Fixes #3643
https://linear.app/buildkite/issue/PS-1503
Changes
Per the description.
Testing
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go tool gofumpt -extra -w .)Disclosures / Credits
I did not use AI tools at all