Extract Common HTTP Client Logic #447
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new
internal/httppackage that provides a common HTTP client for making API requests. The implementation standardizes the way we set up authorization headers, handle errors, and process responses across the codebase.Motivation
Previously, HTTP request setup with authorization appeared in multiple places:
pkg/cmd/api/api.go(apiCaller function)internal/config/token.go(fetchTokenInfo method)Both set up similar HTTP clients, handle authorization, and process responses, but with slightly different approaches. This led to code duplication and potential inconsistencies in error handling. By extracting this common logic into a single package, we can reduce duplication and ensure consistent behavior across the codebase.
Changes
internal/httppackage with:pkg/cmd/api/api.goto use the new HTTP clientinternal/config/token.goto use the new HTTP clientTesting
The changes are covered by new unit tests in the
internal/httppackage.