[SUP-2184] Only write local config in git repo #476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcncl
reviewed
May 27, 2025
Contributor
mcncl
left a comment
mcncl
left a comment
There was a problem hiding this comment.
I think this will also cause issues on configure, where an API token will be required and not allow the user to configure with an incorrect one, but an API token should not be needed for certain commands, like bk pipeline validate.
Signed-off-by: Ben McNicholl <git@benmcnicholl.com>
PriyaSudip
reviewed
Jul 7, 2025
Contributor
PriyaSudip
left a comment
PriyaSudip
left a comment
There was a problem hiding this comment.
Changes looks good, will wait for Test and Lint to go green.
Signed-off-by: Ben McNicholl <git@benmcnicholl.com>
Signed-off-by: Ben McNicholl <git@benmcnicholl.com>
PriyaSudip
approved these changes
Jul 7, 2025
mcncl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not ready for merge!
Running the BK CLI tool from any directory will create a local config. This PR is to change this functionality so that it does not create the local config unless the directory is a valid git repo.