bk configure with org token already present
#498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amp-Thread: https://ampcode.com/threads/T-807f4928-eee4-49c2-b53a-a5cca9671ec4 Co-authored-by: Amp <amp@ampcode.com>
- Add GetTokenForOrg method to config to retrieve tokens for specific organizations
- Modify bk configure to check for existing tokens before prompting
- Display "Using existing API token for organization: {org}" when token exists
- Add comprehensive test coverage for token reuse scenarios
- Maintains backward compatibility for new organizations
Amp-Thread: https://ampcode.com/threads/T-60c7ab55-fc0c-4c76-8855-3d8ba87fd8a0
Co-authored-by: Amp <amp@ampcode.com>
Only write token configuration when it's new, not when reusing existing tokens. This prevents unnecessary file writes when the configuration hasn't changed. Amp-Thread: https://ampcode.com/threads/T-60c7ab55-fc0c-4c76-8855-3d8ba87fd8a0 Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread: https://ampcode.com/threads/T-60c7ab55-fc0c-4c76-8855-3d8ba87fd8a0 Co-authored-by: Amp <amp@ampcode.com>
Update documentation to use the correct golangci-lint command that actually works: `docker-compose -f .buildkite/docker-compose.yaml run golangci-lint golangci-lint run` Amp-Thread: https://ampcode.com/threads/T-60c7ab55-fc0c-4c76-8855-3d8ba87fd8a0 Co-authored-by: Amp <amp@ampcode.com>
Member
Author
|
Discovered the documented lint command was wrong, so updated that too. |
mcncl
approved these changes
Jul 6, 2025
Member
Author
|
🙏 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have an org token already configured:
I go into a directory I haven't used bk in before, and it asks me to configure a token:
So I do:
Hold on - it already knows my token! Why is it asking me, I don't know it!
We should skip this when we already have a token for the matching org. So, that's what this PR does.
(Technically the
bk build viewerror is also incorrect - I have an API token configured, bk just doesn't understand which one to use.)Based on #497 because Amp helped me out:
https://ampcode.com/threads/T-60c7ab55-fc0c-4c76-8855-3d8ba87fd8a0