Add whoami command #512
Merged
Add whoami command #512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moskyb
commented
Jul 23, 2025
pkg/cmd/whoami/whoami.go
Outdated
Comment on lines
61
to
67
| b.WriteString(fmt.Sprintf("Current organization: %s\n", orgSlug)) | ||
| b.WriteRune('\n') | ||
| b.WriteString(fmt.Sprintf("API Token Description: %s\n", token.Description)) | ||
| b.WriteString(fmt.Sprintf("API Token Scopes: %v\n", token.Scopes)) | ||
| b.WriteRune('\n') | ||
| b.WriteString(fmt.Sprintf("API Token user name: %s\n", token.User.Name)) | ||
| b.WriteString(fmt.Sprintf("API Token user email: %s\n", token.User.Email)) |
Contributor
Author
There was a problem hiding this comment.
maybe we should quote these? use %q instead of %s
moskyb
commented
Jul 23, 2025
pkg/cmd/whoami/whoami.go
Outdated
| Token: token, | ||
| } | ||
|
|
||
| err := json.NewEncoder(cmd.OutOrStdout()).Encode(whoamiInfo) |
Contributor
Author
There was a problem hiding this comment.
This marshals without indentation, so it all comes out on one line. The idea of json is to be machine parsable, and we have the exact same information available as human readable, so i don't see it as much of an issue, but i'm happy to change this if people have strong feelings.
Contributor
Author
There was a problem hiding this comment.
eg.
{"organization_slug":"a-very-real-org","token":{"uuid":"00000000-0000-0000-0000-000000000000","scopes":["read_teams","read_pipelines","write_pipelines","graphql"],"description":"My cool token","created_at":"2022-05-20T02:09:18Z","user":{"name":"Benno Moskovitz","email":"ben.m@buildkite.com"}}}
mcncl
reviewed
Jul 23, 2025
Contributor
mcncl
left a comment
mcncl
left a comment
There was a problem hiding this comment.
@moskyb I wrote an output package a while ago which might help here, but open to feedback if it adds unintended complexity
https://github.com/buildkite/cli/blob/main/pkg/output/output.go
Contributor
Author
|
@mcncl good call, added! |
mcncl
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new command to the cli,
whoami. It looks like this:it also has a JSON output mode:
very happy to take notes on the output format -- it was basically just what first came into my head, i'm sure there are better ways to show this information.