-
Notifications
You must be signed in to change notification settings - Fork 49
Add agent pause/resume and build list commands #524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add agent pause/resume commands with note and timeout options - Add build list command with duration and message filtering - Update Go to 1.25 and go-buildkite to v4.7.0 to support pause/resume - Fix job retry segfault on API errors - Include tests for all new functionality
Adding some quick win output formatting, rest look quite comprehensive (such as the bubbletea view) and unnecessary for action items (e.g. pause/resume/download, etc)
- Fix timestamp handling in build list to use promoted methods from embedded time.Time
Added pagination up to a configurable limit, with a maximum of 5000 builds. Enhanced client-side filtering, improved table formatting.
|
May not be immediately apparent, so will comment it here - the 5 mins/1440 mins on the agent pause feature that I am going off on in this PR are actually constraints set by the agent itself - although silently. It will default to 5 min pause if you don't specify. You'd think setting this flag to 0 or higher than 1440 would mean longer, but 0 will result in literally no pause and anything higher than 1440 just won't be respected. Thought I'd clear that up as it may just seem like I'm a crazy person and love magic numbers |
| limit int | ||
| } | ||
|
|
||
| func NewCmdBuildList(f *factory.Factory) *cobra.Command { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it, thank you for adding this! ❤️
Fixes: #519
Fixes: #521
Fixes: #522
Fixes: #523