Skip to content

fix: handle block steps correctly #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mcncl merged 1 commit into from
Oct 16, 2025
Merged

fix: handle block steps correctly #555

mcncl merged 1 commit into from
Oct 16, 2025

Conversation

@mcncl
Copy link
Contributor

@mcncl mcncl commented Oct 16, 2025

Description

block steps don't have a createdAt time, so handling that will cause a segfault

Changes

  • Adds a conditional to check if createdAt is nil and handles it correctly; setting to nil instead of parsing a time from a nil value

@mcncl
fix: handle block steps correctly
d262599 
Signed-off-by: Ben McNicholl <git@benmcnicholl.com>
@mcncl mcncl requested a review from a team as a code owner October 16, 2025 22:57
nsuma8989
nsuma8989 approved these changes Oct 16, 2025
View reviewed changes
Copy link

@nsuma8989 nsuma8989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@mcncl mcncl merged commit 031d9e6 into main Oct 16, 2025
1 check passed
@mcncl mcncl deleted the fix/segfault_build_view branch October 16, 2025 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nsuma8989 nsuma8989 nsuma8989 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mcncl @nsuma8989