Refactor: move logger interface to own package#867
Merged
natalieparellano merged 1 commit intomainfrom Jun 24, 2022
Merged
Conversation
Signed-off-by: Natalie Arellano <narellano@vmware.com>
mboldt
approved these changes
Jun 22, 2022
Contributor
mboldt
left a comment
mboldt
left a comment
There was a problem hiding this comment.
Looks like a good move to me!
Beyond scope for this, but curious if we've considered just using apex directly? Like the advice from that Ultimate Service workshop we attended a while back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use the logger everywhere and it's getting annoying to copy the interface so many times. It also makes it harder for interfaces that take a logger to be in a separate package from their implementation, as we might create an import cycle.