Allow storing multiple commands instead of a single string#900
Merged
natalieparellano merged 9 commits intomainfrom Sep 22, 2022
Merged
Allow storing multiple commands instead of a single string#900natalieparellano merged 9 commits intomainfrom
natalieparellano merged 9 commits intomainfrom
Conversation
natalieparellano
approved these changes
Sep 3, 2022
Member
natalieparellano
left a comment
natalieparellano
left a comment
There was a problem hiding this comment.
@jabrown85 apologies for the slow review! I added a couple comments but overall this LGTM
Contributor
Author
|
@natalieparellano did you want to take another look or 👍 to merge? |
Member
|
@jabrown85 apologies for the slow reply! I made two suggestions for the platform api boundary (this will go out in 0.10, not 0.11) but otherwise this looks good to me! |
This is a first step to implementing #322. This PR is updating our internal structs to allow for a slice of commands while keeping the external API and behavior the same. A future PR will implement handling multiple commands depending on the API version and changing the behavior of the launcher and metadat file output changes. Signed-off-by: Jesse Brown <jabrown85@gmail.com>
Signed-off-by: Jesse Brown <jabrown85@gmail.com>
Signed-off-by: Jesse Brown <jabrown85@gmail.com>
Signed-off-by: Jesse Brown <jabrown85@gmail.com>
Signed-off-by: Jesse Brown <jabrown85@gmail.com> Co-authored-by: Natalie Arellano <narellano@vmware.com> Signed-off-by: Jesse Brown <jabrown85@gmail.com>
jabrown85
force-pushed
the
jab/support-command-array
branch
from
e893f97 to
4851341
Compare
Contributor
Author
|
I need to iterate on this some more after the version changes |
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Fix editing daemon settings Signed-off-by: Jesse Brown <jabrown85@gmail.com>
jabrown85
added a commit
that referenced
this pull request
Sep 22, 2022
Continuation of work in #900. For platform >= 0.10, lifecycle will write command as an array to metadata.toml and the resulting image label. No other intended behavior changes at this time. Previous APIs will continue to write as a string. Signed-off-by: Jesse Brown <jabrown85@gmail.com>
natalieparellano
pushed a commit
that referenced
this pull request
Sep 29, 2022
)" This reverts commit 5fa84a4.
natalieparellano
pushed a commit
that referenced
this pull request
Sep 29, 2022
)" (#919) Signed-off-by: Natalie Arellano <narellano@vmware.com> Signed-off-by: Natalie Arellano <narellano@vmware.com>
jabrown85
added a commit
that referenced
this pull request
Sep 29, 2022
* Allow storing multiple commands instead of a single string This is a first step to implementing #322. This PR is updating our internal structs to allow for a slice of commands while keeping the external API and behavior the same. A future PR will implement handling multiple commands depending on the API version and changing the behavior of the launcher and metadat file output changes. Signed-off-by: Jesse Brown <jabrown85@gmail.com> * Comment on usage of cmp.Option Signed-off-by: Jesse Brown <jabrown85@gmail.com> * Add comment on Matches interface usage for testing Signed-off-by: Jesse Brown <jabrown85@gmail.com> * Added test for launch.toml decoding branching logic Signed-off-by: Jesse Brown <jabrown85@gmail.com> * Apply suggestions from code review Signed-off-by: Jesse Brown <jabrown85@gmail.com> Co-authored-by: Natalie Arellano <narellano@vmware.com> Signed-off-by: Jesse Brown <jabrown85@gmail.com> * fixup! Apply suggestions from code review * fixup! Apply suggestions from code review * Fix editing daemon settings Signed-off-by: Natalie Arellano <narellano@vmware.com> Signed-off-by: Jesse Brown <jabrown85@gmail.com> Signed-off-by: Natalie Arellano <narellano@vmware.com> Co-authored-by: Natalie Arellano <narellano@vmware.com>
natalieparellano
pushed a commit
that referenced
this pull request
Sep 30, 2022
* Allow storing multiple commands instead of a single string (#900) * Allow storing multiple commands instead of a single string This is a first step to implementing #322. This PR is updating our internal structs to allow for a slice of commands while keeping the external API and behavior the same. A future PR will implement handling multiple commands depending on the API version and changing the behavior of the launcher and metadat file output changes. Signed-off-by: Jesse Brown <jabrown85@gmail.com> * Comment on usage of cmp.Option Signed-off-by: Jesse Brown <jabrown85@gmail.com> * Add comment on Matches interface usage for testing Signed-off-by: Jesse Brown <jabrown85@gmail.com> * Added test for launch.toml decoding branching logic Signed-off-by: Jesse Brown <jabrown85@gmail.com> * Apply suggestions from code review Signed-off-by: Jesse Brown <jabrown85@gmail.com> Co-authored-by: Natalie Arellano <narellano@vmware.com> Signed-off-by: Jesse Brown <jabrown85@gmail.com> * fixup! Apply suggestions from code review * fixup! Apply suggestions from code review * Fix editing daemon settings Signed-off-by: Natalie Arellano <narellano@vmware.com> Signed-off-by: Jesse Brown <jabrown85@gmail.com> Signed-off-by: Natalie Arellano <narellano@vmware.com> Co-authored-by: Natalie Arellano <narellano@vmware.com> * WIP Signed-off-by: Natalie Arellano <narellano@vmware.com> * Fixing up existing tests Signed-off-by: Jesse Brown <jabrown85@gmail.com> * Remove now unused process specific decode paths Signed-off-by: Jesse Brown <jabrown85@gmail.com> * fixup! Remove now unused process specific decode paths Signed-off-by: Jesse Brown <jabrown85@gmail.com> * fixup! Remove now unused process specific decode paths Signed-off-by: Jesse Brown <jabrown85@gmail.com> * fixup! Remove now unused process specific decode paths Signed-off-by: Jesse Brown <jabrown85@gmail.com> * fixup! Remove now unused process specific decode paths Signed-off-by: Jesse Brown <jabrown85@gmail.com> * fixup! Remove now unused process specific decode paths Signed-off-by: Jesse Brown <jabrown85@gmail.com> * Clean up more serialization paths Signed-off-by: Jesse Brown <jabrown85@gmail.com> * Remove toml wrapping code Signed-off-by: Jesse Brown <jabrown85@gmail.com> * Added comment on UnmarshalTOML Signed-off-by: Jesse Brown <jabrown85@gmail.com> * Put back code I didn't mean to remove Signed-off-by: Jesse Brown <jabrown85@gmail.com> * Update launch/launch.go Co-authored-by: Natalie Arellano <narellano@vmware.com> Signed-off-by: Jesse Brown <jabrown85@gmail.com> * removed line Signed-off-by: Jesse Brown <jabrown85@gmail.com> Signed-off-by: Jesse Brown <jabrown85@gmail.com> Signed-off-by: Natalie Arellano <narellano@vmware.com> Co-authored-by: Natalie Arellano <narellano@vmware.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a first step to implementing buildpacks/spec#323. This PR is updating our internal structs to allow for a slice of commands while keeping the external API and behavior the same. A future PR will implement handling multiple commands depending on the API version and changing the behavior of the launcher and metadat file output changes.
Signed-off-by: Jesse Brown jabrown85@gmail.com