Skip to content

Platform API changes for run image extension (Dockerfiles phase 3)#347

Merged
natalieparellano merged 14 commits intoplatform/0.12from
run-image-extension/platform
Aug 1, 2023
Merged

Platform API changes for run image extension (Dockerfiles phase 3)#347
natalieparellano merged 14 commits intoplatform/0.12from
run-image-extension/platform

Conversation

@natalieparellano
Copy link
Copy Markdown
Member

Branching off of stack removal for the time being

@natalieparellano natalieparellano requested a review from a team as a code owner January 26, 2023 19:55
@natalieparellano natalieparellano marked this pull request as draft January 26, 2023 19:55
@natalieparellano natalieparellano force-pushed the run-image-extension/platform branch from 0be8037 to 1f399e4 Compare January 26, 2023 20:01
@natalieparellano natalieparellano changed the title Platform API changes for run image extension Platform API changes for run image extension (Dockerfiles phase 3) Feb 1, 2023
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano natalieparellano force-pushed the run-image-extension/platform branch 2 times, most recently from f153892 to b448d5e Compare February 2, 2023 22:35
…t run.toml

Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano natalieparellano force-pushed the run-image-extension/platform branch from b448d5e to ef56944 Compare February 2, 2023 22:38
@natalieparellano natalieparellano marked this pull request as ready for review February 2, 2023 22:40
Co-authored-by: Joe Kutner <jpkutner@gmail.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Natalie Arellano added 2 commits June 5, 2023 10:34
Natalie Arellano added 2 commits June 14, 2023 13:55
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano natalieparellano requested a review from hone July 24, 2023 16:50
@natalieparellano
Copy link
Copy Markdown
Member Author

natalieparellano commented Jul 24, 2023

@hone could I get your 👀 on this one?

Note that it is still branching off of stack-removal/platform, to make the diff easier to parse. We should probably merge #335 before re-pointing this to platform/0.10.

Signed-off-by: Natalie Arellano <narellano@vmware.com>
This is needed when extensions were used to switch (but not extend) the run image
and we need to re-read the target data from the image config.

In such cases, we don't need the run image to exist in a registry,
because we don't need a manifest for kaniko.

Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano
Copy link
Copy Markdown
Member Author

@hone I added one more: 8581965

For further context, see: buildpacks/pack#1850 (comment)

Base automatically changed from stack-removal/platform to platform/0.12 August 1, 2023 15:57
@natalieparellano natalieparellano merged commit 42c59ca into platform/0.12 Aug 1, 2023
@natalieparellano natalieparellano deleted the run-image-extension/platform branch August 1, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants