Merged
Conversation
…acks Signed-off-by: Natalie Arellano <narellano@vmware.com>
Member
|
@natalieparellano so does that mean if a buildpack modifies an env var, does a subsequent buildpack always get what the user provided? |
natalieparellano
force-pushed
the
fix/platform-vars
branch
2 times, most recently
from
dd65575 to
a4a1ee5
Compare
natalieparellano
force-pushed
the
fix/platform-vars
branch
from
a4a1ee5 to
134bdde
Compare
Member
Author
|
@hone I went back to the code to confirm my understanding, and it's even more subtle than what I originally wrote. You can see it here: https://github.com/buildpacks/lifecycle/blob/f8b3419877ceab27f46af0621ec6d9d80650df44/env/env.go#L84-L91 As far as I can tell, this is how it has always worked. So we are just updating the language in the spec to reflect what has been happening all along. |
hone
approved these changes
Aug 1, 2023
Merged
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related discussion: #330 (comment)