Skip to content

Improve guides to use multiple overlays#321

Merged
ChristopheDujarric merged 6 commits intobump-sh:mainfrom
philsturgeon:docs/multiple-overlays
Mar 18, 2025
Merged

Improve guides to use multiple overlays#321
ChristopheDujarric merged 6 commits intobump-sh:mainfrom
philsturgeon:docs/multiple-overlays

Conversation

@philsturgeon
Copy link
Copy Markdown
Contributor

@philsturgeon philsturgeon commented Jan 22, 2025

Using the CLI for mutliple overlays until the GHA supports it (bump-sh/github-action#509).

@netlify
Copy link
Copy Markdown

netlify bot commented Jan 22, 2025

Deploy Preview for bump-content-hub ready!

Name Link
🔨 Latest commit 2ddd996
🔍 Latest deploy log https://app.netlify.com/sites/bump-content-hub/deploys/67d95e29b920650008fe6ac5
😎 Deploy Preview https://deploy-preview-321--bump-content-hub.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Copy Markdown
Member

@paulRbr paulRbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About the overlay changes, we'll soon release the multiple overlay inputs in the GHA. Let's wait for that release to update the examples of the tutorials.

About the CLI docs, it's currently a copy of the CLI repo readme would you mind opening a PR there so review those changes independently?

Thanks!

@philsturgeon
Copy link
Copy Markdown
Contributor Author

philsturgeon commented Jan 28, 2025

@paulRbr aha! I thought it felt familiar.

All CLI changes were made directly to CLI here: bump-sh/cli#647

Then some were brought back over here: #323

This PR is now just about adding examples of multiple overlays and updating things to use the github action where it makes sense.

@philsturgeon philsturgeon force-pushed the docs/multiple-overlays branch 2 times, most recently from 540b5d9 to 842688b Compare January 28, 2025 11:57
@philsturgeon philsturgeon changed the title docs/multiple overlays Improve guides to use multiple overlays Jan 28, 2025
@philsturgeon philsturgeon force-pushed the docs/multiple-overlays branch from d772431 to 3d3f2ec Compare March 18, 2025 11:14
@philsturgeon philsturgeon force-pushed the docs/multiple-overlays branch from 3d3f2ec to def5e06 Compare March 18, 2025 11:24
@philsturgeon philsturgeon force-pushed the docs/multiple-overlays branch from 8832baa to 219bb03 Compare March 18, 2025 11:38
@philsturgeon
Copy link
Copy Markdown
Contributor Author

@ChristopheDujarric @paulRbr I've updated all GitHub Action examples that were using CLI for overlays to use GitHub Actions, including multiple overlays with , separation. Please merge if ready.

Copy link
Copy Markdown
Member

@paulRbr paulRbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great! Thanks a lot Phil for this work. The overlay feature seems really integrated and part of the product like this 🙏

@ChristopheDujarric ChristopheDujarric merged commit 2aece75 into bump-sh:main Mar 18, 2025
5 checks passed
@ChristopheDujarric
Copy link
Copy Markdown
Contributor

Thank you @philsturgeon ! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants