[ Header ] Avatar Image , Github Logged in Button#40
Merged
darshkpatel merged 3 commits intomasterfrom Jul 24, 2020
Merged
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/bundly/dash/5abmedtbc |
sauravhiremath
requested changes
Jul 24, 2020
Member
sauravhiremath
left a comment
sauravhiremath
left a comment
There was a problem hiding this comment.
Reviewed it. LGTM, added a comment. Should be gtg after that
I think we can start adding the screenshots of the UI change in the PRs too. Coz most of our changes would not be visible due to login filter
sauravhiremath
approved these changes
Jul 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added avatar from GitHub profile, more generic placeholder image and logged in button ( static since dashboard can only be seen once logged in via GitHub )