This repository was archived by the owner on Aug 6, 2021. It is now read-only.
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #56 +/- ##
==========================================
- Coverage 98.65% 98.64% -0.01%
==========================================
Files 71 71
Lines 2236 2221 -15
Branches 461 456 -5
==========================================
- Hits 2206 2191 -15
Misses 29 29
Partials 1 1
Continue to review full report at Codecov.
|
firstred
force-pushed
the
bunq-update-13
branch
from
7b4a02a to
c858cb0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the Update 13 changes from the changelog: https://beta.doc.bunq.com/basics/changelog#january-28-2020-bunq-update-13-edition
Signing the URL and headers is deprecated and will be removed soon. Also, there are now a lot of endpoints that do not require signing at all. I have double-checked whether this is true, and indeed, the API ignores the signature for all operations except the ones listed here: https://beta.doc.bunq.com/basics/authentication/signing
Despite these changes, this PR still signs all requests, in case additional endpoints are added, that do require signing. This way, we don't have to think about it anymore.