Add the ability to customize section and field names on save/load.#11
Merged
burner merged 3 commits intoburner:masterfrom Mar 29, 2018
Merged
Add the ability to customize section and field names on save/load.#11burner merged 3 commits intoburner:masterfrom
burner merged 3 commits intoburner:masterfrom
Conversation
|
@burner, if you take this PR please also push a new git tag for DUB. We actually require it for D-Scanner. |
Owner
|
apart of the nitpicks it looks good. thank you. |
burner
requested changes
Mar 28, 2018
source/inifiled.d
Outdated
|
|
||
| if(section) { | ||
| oRange.formattedWrite("[%s]\n", getTypeName!T); | ||
| if (hasUDA!(T, INI)) |
Owner
There was a problem hiding this comment.
could you move the { to the end of the line
source/inifiled.d
Outdated
| auto ini = getINI!(T); | ||
| if (ini.name !is null) | ||
| oRange.formattedWrite("[%s]\n", ini.name); | ||
| else |
Owner
There was a problem hiding this comment.
could you please add curly braces for the two else statements
burner
approved these changes
Mar 29, 2018
Owner
|
@Hackerpilot thank you |
Owner
|
new tag is pushed |
wilzbach
added a commit
to wilzbach/phobos
that referenced
this pull request
Apr 3, 2018
Due to dlang-community/D-Scanner#526, the `.dscanner` prefix was required. However, thanks to burner/inifiled#11 this is no longer needed and DScanner 0.5 doesn't require the prefix anymore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1. Also fixes some spelling mistakes.