Sync with PatrickNLT #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…font, a long text won't scroll Steps to reproduce the bug: * Set a bigger font in Settings -> General -> Accessibility -> Larger text * Type a long text in a UITextField with adjustsFontSizeToFitWidth set to NO (as any QTextField) => Text won't scroll, we don't see anymore what's typed in. The minimum font size that I set is the biggest one that is OK
iOS 9 calls reloadData less agressively than iOS 8 and earlier. If the root of the table view is set too soon (eg. before the data source is set), reloadData may not be called in certain cases, resulting in inconsistencies and inducing crashes.
Removes the black border at the top behind the navigation bar. The contentInset is nicely automatically set, we don't want to reset it.
[QuickDialogTableView] Set root only after data source and delegate are set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.