Skip to content

Support for Python2.6 (without argparse tests)#18

Merged
bw2 merged 4 commits intobw2:masterfrom
kuba:python2.6
Nov 9, 2015
Merged

Support for Python2.6 (without argparse tests)#18
bw2 merged 4 commits intobw2:masterfrom
kuba:python2.6

Conversation

@kuba
Copy link
Contributor

@kuba kuba commented May 2, 2015

partially fixes #17

kuba added 3 commits May 2, 2015 14:22
@kuba
Support for Python2.6 (without tests)
bf0e453
@kuba
fix sys.version_info typo
9e8513d
@kuba
Install and test OK in py2.6 (unittest2, __version__ fixes).
a58b35d 
- add tox py26 env
- install and import unittest2 for py26
- move __version__ to setup.py ("import configargparse" requires
  argparse and ordereddict to be installed before running setup.py...)
- tests are not distributed with PyPI package, so just ignore it
@kuba kuba changed the title Support for Python2.6 (without tests) Support for Python2.6 (without argaparse tests) May 5, 2015
@kuba kuba changed the title Support for Python2.6 (without argaparse tests) Support for Python2.6 (without argparse tests) May 5, 2015
@bw2
Copy link
Owner

bw2 commented May 13, 2015

I've tried merging this pull request with the latest version of master and fixing python2.6 support on this branch:
https://github.com/bw2/ConfigArgParse/tree/python26_support

When I run tox or python2.6 setup.py test though, I get AttributeError: 'module' object has no attribute 'test_configargparse'. Do you think you could fix/update this pull request so I can merge it?

@kuba
Copy link
Contributor Author

kuba commented May 19, 2015

Sorry, @bw2, but I've just seen your reply. Absolutely, feel free add new commits on top of this PR. However, I've merged it with the latest master, so you don't have to do it yourself anymore :)

Notably, I removed configargparse.__version__, so if you need it back, then I would suggest using pkg_resources for establishing currently installed package version, instead of duplicating version string. Let me know if you need it in your API, and I can send a relevant commit.

@kuba kuba mentioned this pull request May 22, 2015
Merged
@kuba
Copy link
Contributor Author

kuba commented May 29, 2015

Friendly ping :)

@kuba
Copy link
Contributor Author

kuba commented Sep 7, 2015

@bw2, could you please merge this in?

@kuba
Copy link
Contributor Author

kuba commented Oct 16, 2015

@bw2, are you still maintaining this project?

@kuba
Copy link
Contributor Author

kuba commented Oct 16, 2015

FYI this is blocking Let's Encrypt support for Python2.6.

@jayvdb
Copy link

jayvdb commented Oct 23, 2015

I am looking at using ConfigArgParse, but need Python 2.6 (unofficial) support. happy to help maintain Python 2.6 compatibility if this is merged.

@kuba
Copy link
Contributor Author

kuba commented Nov 7, 2015

@bw2, should we consider this as a dead project?

jayvdb
jayvdb reviewed Nov 8, 2015
View reviewed changes
setup.py
Copy link

@jayvdb jayvdb Nov 8, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could read the __init__ file, like I do in https://github.com/jayvdb/travis_log_fetch/blob/7c3e6925f77579d3d4e0c73d8e8ccb0151714150/setup.py#L57

@jayvdb
Copy link

jayvdb commented Nov 8, 2015

Could you add Python 2.6 to .travis.yml ?

bw2 added a commit that referenced this pull request Nov 9, 2015
@bw2
Merge pull request #18 from kuba/python2.6
e4ea8ca 
Support for Python2.6 (without argparse tests)
@bw2 bw2 merged commit e4ea8ca into bw2:master Nov 9, 2015
@bw2
Copy link
Owner

bw2 commented Nov 9, 2015

@kuba and @jayvdb - sorry it took this long. Hope this merge is still useful to you guys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Python 2.6 support

3 participants

@kuba @bw2 @jayvdb