Code review: matrix layout and export cropping fixes#21
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix matrix layout and export cropping
Code review: matrix layout and export cropping fixes
Jan 7, 2026
byemaxx
approved these changes
Jan 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comprehensive review of PR #16 fixes for matrix visualization layout and export issues. All previous review feedback has been addressed through sub-PRs #17-#20.
Verified Fixes
Export cropping (js/utils/export-tools.js)
rect.widthbefore defaulting to1shrinkToContentcondition extracted once, eliminating duplicate boolean coercionundefinedinitializationResizeObserver memory leak (js/renderers/comparison-renderer.js)
comparison-renderer-store.jswith proper disconnect on cleanupdocument.bodytomatrixContainerfor efficient, targeted resize detection0.92extracted toMATRIX_FILL_RATIO_THRESHOLDwith documented rationaleCSS consistency (css/comparison.css)
.comparison-matrix-grid > .matrix-cell.empty-cell:first-childArchitecture
The fixes maintain the wrapper/container pattern for adaptive layout:
Export strategy detects matrix mode and applies shrink-to-content to avoid capturing centered empty margins.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.